"If they lived in one state for 7 out of 12 months, just allocate 7/12th of the gain/loss to that state."

That works for interest on a savings account.  But with stock sales, if they had a $1,000,000 gain on January 15 and a $999,000 loss on December 15, that method isn't going to make the first state very happy.